[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

This is a good addition.  However, it seems to me that since you only need an ArchSpec to make one of these Architecture plugins, which plugin you get seems fully determined by the Target, not the Process.  I understand that the only need for it at present is to do a Process-related task.  But that task actually takes a Thread as a parameter, so it doesn't need to know it's containing process to do its job.   And it seems like it diminishes the plugin's future utility to have it more limited in scope than it needs to be.

What do you think?


https://reviews.llvm.org/D31172