[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

[Ravitheja Addepally via Phabricator via lldb-commits]

ravitheja added inline comments.


================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:32-35
+  RegisterPacketHandler(
+      StringExtractorGDBRemote::eServerPacketType_QEnableErrorStrings,
+      [this](StringExtractorGDBRemote packet, Status &error, bool &interrupt,
+             bool &quit) { return this->Handle_QErrorStringEnable(packet); });
----------------
clayborg wrote:
> Why is this done here and not where all of the other packets are registered?
I did it here coz this class has the member SendErrorResponse which I wanted to overload. Also I think the remote packets are a bit spreadout among inherited classes, so it will be available for all these classes and then these won't be spread out like packet handling code will be in one place.


https://reviews.llvm.org/D34945