[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Looks good. Just one question on why we register a packet handler.



================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:32-35
+  RegisterPacketHandler(
+      StringExtractorGDBRemote::eServerPacketType_QEnableErrorStrings,
+      [this](StringExtractorGDBRemote packet, Status &error, bool &interrupt,
+             bool &quit) { return this->Handle_QErrorStringEnable(packet); });
----------------
Why is this done here and not where all of the other packets are registered?


https://reviews.llvm.org/D34945