[Lldb-commits] [PATCH] D34746: Move Timer and TraceOptions from Core to Utility

[Zachary Turner via lldb-commits]

Cool, lgtm
On Thu, Jun 29, 2017 at 5:52 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath updated this revision to Diff 104624.
> labath added a comment.
>
> That's a good idea. This time I almost smuggled in a (unused) Host include
> into
> Utility -- it was a leftover from the Host::ThreadLocalStorage times. I'll
> make
> sure to run it in the future.
>
> After fixing that issue, I see no differences in the output.
>
>
> https://reviews.llvm.org/D34746
>
> Files:
>   include/lldb/Core/Timer.h
>   include/lldb/Core/TraceOptions.h
>   include/lldb/Host/common/NativeProcessProtocol.h
>   include/lldb/Target/Process.h
>   include/lldb/Utility/Timer.h
>   include/lldb/Utility/TraceOptions.h
>   source/API/SBTraceOptions.cpp
>   source/API/SystemInitializerFull.cpp
>   source/Commands/CommandObjectFrame.cpp
>   source/Commands/CommandObjectLog.cpp
>   source/Commands/CommandObjectTarget.cpp
>   source/Core/CMakeLists.txt
>   source/Core/Disassembler.cpp
>   source/Core/Mangled.cpp
>   source/Core/Module.cpp
>   source/Core/Timer.cpp
>   source/Host/common/Symbols.cpp
>   source/Host/posix/ConnectionFileDescriptorPosix.cpp
>   source/Initialization/SystemInitializerCommon.cpp
>   source/Interpreter/CommandInterpreter.cpp
>
> source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
>   source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp
>   source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
>   source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp
>   source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
>   source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
>   source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
>   source/Plugins/Process/Linux/ProcessorTrace.h
>   source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
>   source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
>   source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
>   source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
>   source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp
>   source/Plugins/SymbolFile/DWARF/DWARFDebugPubnames.cpp
>   source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
>   source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
>   source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp
>   source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
>   source/Symbol/DWARFCallFrameInfo.cpp
>   source/Symbol/ObjectFile.cpp
>   source/Symbol/Symtab.cpp
>   source/Target/ObjCLanguageRuntime.cpp
>   source/Target/Target.cpp
>   source/Target/TargetList.cpp
>   source/Utility/CMakeLists.txt
>   source/Utility/Timer.cpp
>   unittests/Core/CMakeLists.txt
>   unittests/Core/TimerTest.cpp
>   unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
>   unittests/Utility/CMakeLists.txt
>   unittests/Utility/TimerTest.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170629/8fca0cc2/attachment.html>