Cool, lgtm<br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 29, 2017 at 5:52 AM Pavel Labath via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath updated this revision to Diff 104624.<br>
labath added a comment.<br>
<br>
That's a good idea. This time I almost smuggled in a (unused) Host include into<br>
Utility -- it was a leftover from the Host::ThreadLocalStorage times. I'll make<br>
sure to run it in the future.<br>
<br>
After fixing that issue, I see no differences in the output.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D34746" rel="noreferrer" target="_blank">https://reviews.llvm.org/D34746</a><br>
<br>
Files:<br>
  include/lldb/Core/Timer.h<br>
  include/lldb/Core/TraceOptions.h<br>
  include/lldb/Host/common/NativeProcessProtocol.h<br>
  include/lldb/Target/Process.h<br>
  include/lldb/Utility/Timer.h<br>
  include/lldb/Utility/TraceOptions.h<br>
  source/API/SBTraceOptions.cpp<br>
  source/API/SystemInitializerFull.cpp<br>
  source/Commands/CommandObjectFrame.cpp<br>
  source/Commands/CommandObjectLog.cpp<br>
  source/Commands/CommandObjectTarget.cpp<br>
  source/Core/CMakeLists.txt<br>
  source/Core/Disassembler.cpp<br>
  source/Core/Mangled.cpp<br>
  source/Core/Module.cpp<br>
  source/Core/Timer.cpp<br>
  source/Host/common/Symbols.cpp<br>
  source/Host/posix/ConnectionFileDescriptorPosix.cpp<br>
  source/Initialization/SystemInitializerCommon.cpp<br>
  source/Interpreter/CommandInterpreter.cpp<br>
  source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp<br>
  source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp<br>
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp<br>
  source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp<br>
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp<br>
  source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp<br>
  source/Plugins/Platform/MacOSX/PlatformDarwin.cpp<br>
  source/Plugins/Process/Linux/ProcessorTrace.h<br>
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp<br>
  source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp<br>
  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp<br>
  source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp<br>
  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp<br>
  source/Plugins/SymbolFile/DWARF/DWARFDebugPubnames.cpp<br>
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp<br>
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp<br>
  source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp<br>
  source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp<br>
  source/Symbol/DWARFCallFrameInfo.cpp<br>
  source/Symbol/ObjectFile.cpp<br>
  source/Symbol/Symtab.cpp<br>
  source/Target/ObjCLanguageRuntime.cpp<br>
  source/Target/Target.cpp<br>
  source/Target/TargetList.cpp<br>
  source/Utility/CMakeLists.txt<br>
  source/Utility/Timer.cpp<br>
  unittests/Core/CMakeLists.txt<br>
  unittests/Core/TimerTest.cpp<br>
  unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp<br>
  unittests/Utility/CMakeLists.txt<br>
  unittests/Utility/TimerTest.cpp<br>
<br>
</blockquote></div>