[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

[Chris Bieneman via Phabricator via lldb-commits]

beanz added a comment.

My intention in this patch is not in any way to adversely impact the Xcode project, which is the supported and documented way to build LLDB on OS X (http://lldb.llvm.org/build.html#BuildingLldbOnMacOSX).

The goal of this patch is to support configuration time capabilities inspection to aid in porting LLDB to other platforms via the CMake build system. By leaving the Host/Config.h header in LLDB's source tree we continue supporting the Xcode project, and we don't require changing the LLDB sources which include lldb/Host/Config.h. This seems like the best solution to me.



================
Comment at: cmake/modules/LLDBConfig.cmake:287-293
+  install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/include/
+    COMPONENT lldb_headers
+    DESTINATION include
+    FILES_MATCHING
+    PATTERN "*.h"
+    PATTERN ".svn" EXCLUDE
+    PATTERN ".cmake" EXCLUDE
----------------
zturner wrote:
> Is this necessary?
CMake's documentation does not specify the order in which directories may be processed, and since the source and build directories will have an overlapping Config.h file we need to make sure the right one gets picked every time regardless of any changes to how CMake might handle the underlying implementation of the install command.


https://reviews.llvm.org/D31969