[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Thank you very much. I am soo happy that these files are going away.

In https://reviews.llvm.org/D31969#724508, @zturner wrote:

> How much would it complicate things to move the hand maintained files out of tree?  If the Xcode build isn't really a thing we're officially supporting, perhaps we can take that aggressive approach in-tree as well?


AFAIK, the xcode project already passes some additional -D flags to the compiler when building lldb. It shouldn't be too hard (for someone who knows how to edit xcode projects :) ) to add these two flags there and delete the hand-written Config.h. I don't feel too strongly about that though.


https://reviews.llvm.org/D31969