[Lldb-commits] [PATCH] D31451: New C++ function name parsing logic

[Eugene Zemtsov via lldb-commits]

Sorry about that and thanks for rolling it back. I'll take a look tomorrow.

On Tue, Apr 4, 2017 at 5:22 PM, Jim Ingham <jingham at apple.com> wrote:

> This patch is causing a testsuite failure in ObjC breakpoint setting:
>
> functionalities/breakpoint/objc/TestObjCBreakpoints.py
>
> You must be grabbing ObjC names and somehow treating them as C++ names.
>
> I reverted the patch till the test gets fixed.  If you can't get your
> hands on
> an ObjC binary to test I can send you one.  You don't need to run code,
> you just
> need to load a binary, which you should be able to do on any lldb host.
>
> Jim
>
>
> > On Apr 3, 2017, at 12:12 PM, Eugene Zemtsov via Phabricator <
> reviews at reviews.llvm.org> wrote:
> >
> > This revision was automatically updated to reflect the committed changes.
> > Closed by commit rL299374: New C++ function name parsing logic (authored
> by eugene).
> >
> > Changed prior to commit:
> >  https://reviews.llvm.org/D31451?vs=93694&id=93910#toc
> >
> > Repository:
> >  rL LLVM
> >
> > https://reviews.llvm.org/D31451
> >
> > Files:
> >  lldb/trunk/source/Plugins/Language/CPlusPlus/CMakeLists.txt
> >  lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
> >  lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h
> >  lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp
> >  lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.h
> >  lldb/trunk/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp
> >
> > <D31451.93910.patch>
>
>


-- 
Thanks,
Eugene Zemtsov.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170404/eace783b/attachment.html>