<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">Sorry about that and thanks for rolling it back. I'll take a look tomorrow. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 4, 2017 at 5:22 PM, Jim Ingham <span dir="ltr"><<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch is causing a testsuite failure in ObjC breakpoint setting:<br>
<br>
functionalities/breakpoint/<wbr>objc/TestObjCBreakpoints.py<br>
<br>
You must be grabbing ObjC names and somehow treating them as C++ names.<br>
<br>
I reverted the patch till the test gets fixed.  If you can't get your hands on<br>
an ObjC binary to test I can send you one.  You don't need to run code, you just<br>
need to load a binary, which you should be able to do on any lldb host.<br>
<br>
Jim<br>
<div><div class="h5"><br>
<br>
> On Apr 3, 2017, at 12:12 PM, Eugene Zemtsov via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br>
><br>
> This revision was automatically updated to reflect the committed changes.<br>
> Closed by commit rL299374: New C++ function name parsing logic (authored by eugene).<br>
><br>
> Changed prior to commit:<br>
>  <a href="https://reviews.llvm.org/D31451?vs=93694&id=93910#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D31451?vs=93694&id=93910#toc</a><br>
><br>
> Repository:<br>
>  rL LLVM<br>
><br>
> <a href="https://reviews.llvm.org/D31451" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D31451</a><br>
><br>
> Files:<br>
>  lldb/trunk/source/Plugins/<wbr>Language/CPlusPlus/CMakeLists.<wbr>txt<br>
>  lldb/trunk/source/Plugins/<wbr>Language/CPlusPlus/<wbr>CPlusPlusLanguage.cpp<br>
>  lldb/trunk/source/Plugins/<wbr>Language/CPlusPlus/<wbr>CPlusPlusLanguage.h<br>
>  lldb/trunk/source/Plugins/<wbr>Language/CPlusPlus/<wbr>CPlusPlusNameParser.cpp<br>
>  lldb/trunk/source/Plugins/<wbr>Language/CPlusPlus/<wbr>CPlusPlusNameParser.h<br>
>  lldb/trunk/unittests/Language/<wbr>CPlusPlus/<wbr>CPlusPlusLanguageTest.cpp<br>
><br>
</div></div>> <D31451.93910.patch><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><font face="verdana, sans-serif">Thanks,</font><div><font face="verdana, sans-serif">Eugene Zemtsov.</font></div></div></div>
</div>