[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

[Nitesh Jain via Phabricator via lldb-commits]

nitesh.jain added inline comments.


================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:220
+  // information. Hence we need to relied on target architecture for that.
+  if (arch.IsValid() && !arch.IsMIPS())
+    GetTarget().SetArchitecture(arch);
----------------
labath wrote:
> Here you copy the architecture from core to target.
Actually we are skipping it , if the arch is MIPS ( ! arch.IsMIPS()).  


https://reviews.llvm.org/D31280