[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 20 04:47:49 PDT 2017

krytarowski added inline comments.

Comment at: include/lldb/Host/HostInfo.h:55
+#elif defined(__OpenBSD__)
+#include "lldb/Host/openbsd/HostInfoOpenBSD.h"
+#define HOST_INFO_TYPE HostInfoOpenBSD
kettenis wrote:
> krytarowski wrote:
> > I would sort includes here.
> Do you want me to sort the entire list?
Yes, here and in other places as well. We might get more targets and it's better to keep it in order.

Comment at: source/Plugins/Platform/OpenBSD/PlatformOpenBSD.cpp:158
+    case 1:
+      triple.setArchName("i386");
+      break;
kettenis wrote:
> labath wrote:
> > As far as I can tell, you're only adding x86_64 support, so you should probably remove the others.
> True.  I trimmed the list that FreeBSD had.  My intention is to submit support for all these architectures. But I can leave the currently unsupported ones out.
This is what I'm doing in NetBSD. Adding x86_64 first, i386 next and later the rest -- perhaps starting with arm 32-bit.



More information about the lldb-commits mailing list