[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+  
+    void *dlsym(void* handle, const char* symbol);
+    int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const char **object_type);
----------------
kubamracek wrote:
> clayborg wrote:
> > Doesn't "dlsym" work on all platforms? Windows? 
> Right, it probably doesn't work on Windows.  I'll put in a FIXME/TODO (TSan currenly only works on POSIX anyway), okay?
Now worries, you can also #ifdef around it if needed and put the code needed for windows right in the expression text here. Does TSAN current work on Windows? If so it seems like bug to not support this feature on windows?


https://reviews.llvm.org/D30024