[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

[Kuba (Brecka) Mracek via Phabricator via lldb-commits]

kubamracek added inline comments.


================
Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+  
+    void *dlsym(void* handle, const char* symbol);
+    int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const char **object_type);
----------------
clayborg wrote:
> Doesn't "dlsym" work on all platforms? Windows? 
Right, it probably doesn't work on Windows.  I'll put in a FIXME/TODO (TSan currenly only works on POSIX anyway), okay?


https://reviews.llvm.org/D30024