[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Yeah, I'm starting to remember this a bit.  For some reason, we have individual log channels with verbose as a category (LIBLLDB_LOG_VERBOSE, POSIX_LOG_VERBOSE, KDP_LOG_VERBOSE)  and we have LLDB_LOG_OPTION_VERBOSE which is set "GetVerbose" is testing for.

So you can do:

log enable -v lldb memory

or

log enable lldb memory verbose

and they will do different things depending on who checks what.  That seems really confusing.  We should remove the verbose category and have everybody check GetVerbose instead.  But that's orthogonal to this patch.


https://reviews.llvm.org/D28616