[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 12 13:41:36 PST 2017

labath added a comment.

In https://reviews.llvm.org/D28616#644287, @jingham wrote:

> Is this going to make passing LIBLLDB_LOG_OPTION_VERBOSE to GetLogIfAllCategoriesSet into a "you can't see these logs" operation?
>   I use this in a couple places where I have detailed information that I usually don't want to see, but in some odd cases I might need it.  Loosing this capability would be a shame.

That is not going to be affected - I am not touching that flag. I am removing a *separate* flag on the Stream level, which was never set (although some of the (effectively dead) code did test for it's existence). See old and new implementations of Log::GetVerbose to see what I mean.


More information about the lldb-commits mailing list