[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Most of the DWARF stuff is about to go away anyway in favor of using the LLVM DWARF parser as I am currently modifying it to support all we need in LLDB so we can get rid of the entire DWARF parsers, so many of these changes are fine.

Just fix the definition of eBinary to be (1<<0) and this is good to go.



================
Comment at: include/lldb/Core/Stream.h:36
   enum {
-    eVerbose = (1 << 0),   ///< If set, verbose logging is enabled
-    eDebug = (1 << 1),     ///< If set, debug logging is enabled
-    eAddPrefix = (1 << 2), ///< Add number prefixes for binary, octal and hex
-                           ///when eBinary is clear
     eBinary = (1 << 3) ///< Get and put data as binary instead of as the default
                        ///string mode.
----------------
No one serializes this flag or sets it manually, so make it equal to (1<<0).


https://reviews.llvm.org/D28616