[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, zturner.
labath added subscribers: lldb-commits, beanz.
Herald added a subscriber: aprantl.

I came across this while trying to understand what Log::Debug does. It turns out
it does not do anything, as there is no instance of someone setting a debug flag
on a stream. The same is true for the Verbose and AddPrefix flags. Removing
these will enable some cleanups in the Logging class, and it brings us closer
towards the long term goal of standardizing on llvm stream classes.

I have removed these flags and all code the code which tested for their
presence -- there wasn't much of it, mostly in SymbolFileDWARF, which is
probably going away at some point anyway.

The eBinary flag still has some users, so I am letting it life for the time
being.


https://reviews.llvm.org/D28616

Files:
  include/lldb/Core/Stream.h
  source/Core/Log.cpp
  source/Core/SearchFilter.cpp
  source/Core/Stream.cpp
  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp
  source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
  source/Symbol/Declaration.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28616.84143.patch
Type: text/x-patch
Size: 18866 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170112/ae53be7c/attachment.bin>