[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 10 13:35:24 PST 2017
labath added a comment.
I wouldn't put just "error" as it is quite superfluous ("No such file." sounds like an error even without that prefix). And then you don't have the option to remove it if you need it for some reason (unless you add more format options...). I'd keep it without it, as it is easy to add it manually if you need it.
Adding the error category sounds like a better idea. I am fine without it, but I can add it if you want to.
If we're going to be changing stuff, I'd consider changing the success case to print "Success". (But I'd also change the AsCString method to keep things consistent).
More information about the lldb-commits