[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: include/lldb/Core/Error.h:308-309
+                     llvm::StringRef Options) {
+    llvm::format_provider<llvm::StringRef>::format(error.AsCString(), OS,
+                                                   Options);
+  }
----------------
clayborg wrote:
> Do we want to prefix this output with "error: " followed by the error string?
If we prefix it by something, then perhaps we should incldue the error category as well.  Is it a Windows error, a generic error, a posix error?

(Note that in the future I still would like to kill `lldb::Error` and replace it with `llvm::Error` which is much safer / more extensible, but no objection to this kind of change going in in the interim.)


https://reviews.llvm.org/D28519