[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

[Pavel Labath via lldb-commits]

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

Looks fine in principle, but please encapsulate this better.



================
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py:569
             self.assertIsNotNone(p_response)
+            triple = lldb.DBG.GetSelectedPlatform().GetTriple()
+
----------------
Let's encapsulate the `if(mips)` dance in a separate function (`getExpectedBitsize(reg_info, reg_infos)`, for example) and not bloat the general function with it.


https://reviews.llvm.org/D27088