[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

[Luke Drummond via lldb-commits]

ldrumm added inline comments.


================
Comment at: scripts/Python/prepare_binding_Python.py:229
         stderr=subprocess.PIPE,
-        shell=True)
+    )
     # Wait for SWIG process to terminate
----------------
granata.enrico wrote:
> This worries me a little bit.. Are we sure we are not in any way relying on the shell in executing the command line?
The features of the shell are not used in this expression at all, and the environment is identical to the previous invocation.


https://reviews.llvm.org/D26757