[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

Enrico Granata via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 16 11:40:41 PST 2016


granata.enrico added inline comments.


================
Comment at: scripts/Python/prepare_binding_Python.py:229
         stderr=subprocess.PIPE,
-        shell=True)
+    )
     # Wait for SWIG process to terminate
----------------
This worries me a little bit.. Are we sure we are not in any way relying on the shell in executing the command line?


https://reviews.llvm.org/D26757





More information about the lldb-commits mailing list