[Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

[Zachary Turner via lldb-commits]

Me too, just wanted to make sure with such a large change.  Anyway LGTM

On Wed, Nov 2, 2016 at 10:43 AM Malcolm Parsons <malcolm.parsons at gmail.com>
wrote:

> malcolm.parsons added a comment.
>
> In https://reviews.llvm.org/D26233#586005, @zturner wrote:
>
> > Nice improvement.  I assume you ran the test suite and everything passed?
>
>
> I think a change like this would fail to compile if it was wrong.
>
> check-lldb passed:
> ==================
>
> Issue Details
> =============
>
> UNEXPECTED SUCCESS: test_continue_in_watchpoint_command_dwarf
> (functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py)
> UNEXPECTED SUCCESS: test_continue_in_watchpoint_command_dwo
> (functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py)
> UNEXPECTED SUCCESS: test_dwarf
> (functionalities/thread/exit_during_break/TestExitDuringBreak.py)
> UNEXPECTED SUCCESS: test_dwo
> (functionalities/thread/exit_during_break/TestExitDuringBreak.py)
> UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwarf
> (api/multithreaded/TestMultithreaded.py)
> UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwo
> (api/multithreaded/TestMultithreaded.py)
> UNEXPECTED SUCCESS: test_with_dwarf (lang/cpp/printf/TestPrintf.py)
> UNEXPECTED SUCCESS: test_with_dwo (lang/cpp/printf/TestPrintf.py)
>
>
>
>
> Test Result Summary
> ===================
>
> Test Methods:       1868
> Reruns:                0
> Success:            1099
> Expected Failure:    116
> Failure:               0
> Error:                 0
> Exceptional Exit:      0
> Unexpected Success:    8
> Skip:                645
> Timeout:               0
> Expected Timeout:      0
> [100%] Built target check-lldb
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D26233
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161102/18194d44/attachment.html>