<div dir="ltr">Me too, just wanted to make sure with such a large change.  Anyway LGTM</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 2, 2016 at 10:43 AM Malcolm Parsons <<a href="mailto:malcolm.parsons@gmail.com">malcolm.parsons@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">malcolm.parsons added a comment.<br class="gmail_msg">
<br class="gmail_msg">
In <a href="https://reviews.llvm.org/D26233#586005" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26233#586005</a>, @zturner wrote:<br class="gmail_msg">
<br class="gmail_msg">
> Nice improvement.  I assume you ran the test suite and everything passed?<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
I think a change like this would fail to compile if it was wrong.<br class="gmail_msg">
<br class="gmail_msg">
check-lldb passed:<br class="gmail_msg">
==================<br class="gmail_msg">
<br class="gmail_msg">
Issue Details<br class="gmail_msg">
=============<br class="gmail_msg">
<br class="gmail_msg">
UNEXPECTED SUCCESS: test_continue_in_watchpoint_command_dwarf (functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py)<br class="gmail_msg">
UNEXPECTED SUCCESS: test_continue_in_watchpoint_command_dwo (functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py)<br class="gmail_msg">
UNEXPECTED SUCCESS: test_dwarf (functionalities/thread/exit_during_break/TestExitDuringBreak.py)<br class="gmail_msg">
UNEXPECTED SUCCESS: test_dwo (functionalities/thread/exit_during_break/TestExitDuringBreak.py)<br class="gmail_msg">
UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwarf (api/multithreaded/TestMultithreaded.py)<br class="gmail_msg">
UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwo (api/multithreaded/TestMultithreaded.py)<br class="gmail_msg">
UNEXPECTED SUCCESS: test_with_dwarf (lang/cpp/printf/TestPrintf.py)<br class="gmail_msg">
UNEXPECTED SUCCESS: test_with_dwo (lang/cpp/printf/TestPrintf.py)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Test Result Summary<br class="gmail_msg">
===================<br class="gmail_msg">
<br class="gmail_msg">
Test Methods:       1868<br class="gmail_msg">
Reruns:                0<br class="gmail_msg">
Success:            1099<br class="gmail_msg">
Expected Failure:    116<br class="gmail_msg">
Failure:               0<br class="gmail_msg">
Error:                 0<br class="gmail_msg">
Exceptional Exit:      0<br class="gmail_msg">
Unexpected Success:    8<br class="gmail_msg">
Skip:                645<br class="gmail_msg">
Timeout:               0<br class="gmail_msg">
Expected Timeout:      0<br class="gmail_msg">
[100%] Built target check-lldb<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D26233" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26233</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>