[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

Francis Ricci via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 3 10:35:48 PDT 2016


fjricci added a comment.

The problem with the existing code is that file names are required to be unique, but method names are not. So if the user wants to disable an individual test method with a non-unique name, there is no way to do so. This patch still allows the tests to be disabled by file name, but removes the ability to disable by only method name, instead requiring the method name as a modifier to the file.

I may have used the wrong terminology when I said <TestCase>.<TestMethod>. Here, I meant essentially what is printed by the test runner when a test fails. So, for example:

`BadAddressBreakpointTestCase.test_bad_address_breakpoints_dwarf`
`LldbGdbServerTestCase.test_Hc_then_Csignal_signals_correct_thread_launch_llgs`

These names are guaranteed to be unique, and so I think they're the better way to go. The user can still disable an entire file, by passing something something like:

`TestConcurrentEvents`


https://reviews.llvm.org/D24988





More information about the lldb-commits mailing list