[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

[Todd Fiala via lldb-commits]

tfiala added a comment.

Hey @fjricci ,

What is the motivation for this change?  It looks like the existing code works based on file names, which are required to be unique in the system.  It looks like you're attempting to move it over to a classname.method scheme.  Is that right?  If so, classname.method is not guaranteed to be unique, either.  It would have to include the module name, which is essentially the file name, which is required to be unique.  (Maybe when you said <TestCase>.<TestMethod>, your <TestCase> element is fully qualified, including the module name?  If so, then that should be guaranteed to be unique).

All the same, I'd like to better understand what you're looking to accomplish, since what I'm reading in the description seems to be doing the opposite of what I think you're trying to do.  (I'm probably just misunderstanding).

Thanks!


https://reviews.llvm.org/D24988