[Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 20 21:59:32 PDT 2016

tfiala marked an inline comment as done.

Comment at: source/Core/Disassembler.cpp:292-294
@@ -291,2 +291,5 @@
       decl_line.line = func_decl_line;
+      // TODO do we care about column on these entries?  If so, we need to
+      // plumb that through GetStartLineSourceInfo.
+      decl_line.column = 0;
I will leave this for a potential follow-up patch at another time.  At that point, I would suggest enabling stop line and column marking on the "source list" command, which currently doesn't mark up a displayed line that coincides with any currently-stopped thread.

I'll strip out this TODO on the final check-in.


More information about the lldb-commits mailing list