[Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

[Todd Fiala via lldb-commits]

tfiala updated this revision to Diff 71996.
tfiala added a comment.

This change addresses Jim's and Greg's suggestions.

- stop-show-column now is a quad-state:
  - ansi-or-caret (default):  Shows ANSI if color is enabled; otherwise, uses the text-based caret.
  - ansi-only:  ANSI highlighting is used if color is enabled; otherwise, no column marking.
  - caret-only: text-based caret on the following line will always be used when showing stop column.
  - none: no column marking is done.

- stop-show-column-decorator-pre: this is a format entity (with tab completion for ${ansi.*} codes).  It defaults to the start code for underlining (${ansi.underline}), the default column stop marker display style when using ANSI highlighting.
- stop-show-column-decorator-post: this is the format entity for disabling whatever was enabled in the "-pre" setting.  This defaults to ${ansi.stop}.  This would need to be changed if color codes were used for background/foreground of anything other than inverse.

- other minor odds and ends, like changing the constructor of SourceManager::File to either take a Target or a Debugger, but not both.


https://reviews.llvm.org/D20835

Files:
  include/lldb/API/SBSourceManager.h
  include/lldb/Core/Debugger.h
  include/lldb/Core/Disassembler.h
  include/lldb/Core/SourceManager.h
  include/lldb/lldb-enumerations.h
  packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/settings/TestSettings.py
  packages/Python/lldbsuite/test/source-manager/TestSourceManager.py
  scripts/interface/SBSourceManager.i
  source/API/SBSourceManager.cpp
  source/Commands/CommandObjectSource.cpp
  source/Core/Debugger.cpp
  source/Core/Disassembler.cpp
  source/Core/SourceManager.cpp
  source/Target/StackFrame.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20835.71996.patch
Type: text/x-patch
Size: 34812 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160920/25cb7d01/attachment-0001.bin>