[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 15 04:55:09 PDT 2016

labath added inline comments.

Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1183
@@ +1182,3 @@
+  case dwarf_config5_mips64:
+    return reg_info->byte_offset;
+  case dwarf_cause_mips:
Why do we need to do this remapping? Couldn't we structure the register infos in a way that reg_info->byte_offset is exactly the offset that ptrace expects?

Or are you saying that ptrace does not accept register offsets, but some random register numbers instead? (I cannot tell, as the comment above is confusing.)

Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1222
@@ +1221,3 @@
+  if (reg_info->invalidate_regs)
+    assert(false && "In MIPS, reg_info->invalidate_regs is unhandled");
This seems like a pretty complicated way to write `assert(!reg_info->invalidate_regs);`


More information about the lldb-commits mailing list