[Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

[Zachary Turner via lldb-commits]

Sorry, it's based on a few patches i have locally that I didn't put up for
review but can't commit yet
On Tue, Aug 30, 2016 at 6:13 AM Pavel Labath <labath at google.com> wrote:

> labath added a comment.
>
> Which revision is this patch against? It does not seem to apply cleanly to
> trunk for me. Could you try running the test suite on linux or mac as well,
> as the last StringRef change left things in a pretty broken state there
> (you are changing code which is pretty-much unused on windows)? If not I
> can give it a shot once it the merge issues are resolved.
>
> Apart from that, I like the direction this is going in.
>
>
> ================
> Comment at: unittests/Utility/StringExtractorTest.cpp:76
> @@ +75,3 @@
> +    EXPECT_EQ("ExtractorTest::Consume()", ex.Peek());
> +    ;
> +}
> ----------------
> This seems unnecessary.
>
>
> https://reviews.llvm.org/D24013
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160830/a0a29536/attachment.html>