[Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

[Pavel Labath via lldb-commits]

labath added a comment.

Which revision is this patch against? It does not seem to apply cleanly to trunk for me. Could you try running the test suite on linux or mac as well, as the last StringRef change left things in a pretty broken state there (you are changing code which is pretty-much unused on windows)? If not I can give it a shot once it the merge issues are resolved.

Apart from that, I like the direction this is going in.


================
Comment at: unittests/Utility/StringExtractorTest.cpp:76
@@ +75,3 @@
+    EXPECT_EQ("ExtractorTest::Consume()", ex.Peek());
+    ;
+}
----------------
This seems unnecessary.


https://reviews.llvm.org/D24013