[Lldb-commits] [PATCH] D23545: Minidump parsing

[Dimitar Vlahovski via lldb-commits]

dvlahovski added inline comments.

================
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:260
@@ +259,3 @@
+
+    uint8_t number_of_processors;
+    uint8_t product_type;
----------------
amccarth wrote:
> I'll concede that the static_assert is useful.  Given that, showing the arithmetic explicitly will be helpful when one of these assertions trips, because you'll be able to see how it's supposed to correspond to the struct.
Yes that was my inital insentive to write explicitly the arithmetic


https://reviews.llvm.org/D23545