[Lldb-commits] [PATCH] D23545: Minidump parsing

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 18 11:10:33 PDT 2016

zturner added inline comments.

Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:133
@@ +132,3 @@
+// This matches the Linux kernel definitions from <asm/hwcaps.h>
+enum MinidumpPCPUInformationARMElfHwCaps
dvlahovski wrote:
> amccarth wrote:
> > zturner wrote:
> > > Should this be `enum class`?
> > These look like individual bits that will be bitwise-ORed together, which is trickier to do with an enum class.
> > 
> > But you may still want to specify the underlying type, like `uint32_t`.
> Yes, forgot to change it ...
Yea, see my earlier comment.  This enum uses `LLVM_MARK_AS_BITMASK_ENUM()` which makes this possible.


More information about the lldb-commits mailing list