[Lldb-commits] [PATCH] D22457: Unify process launching code on linux

[Tamas Berghammer via lldb-commits]

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

Looks good with 2 minor comments


================
Comment at: source/Host/linux/ProcessLauncherLinux.cpp:28-29
@@ +27,4 @@
+
+// If there is no PATH variable specified inside the environment then set the path to /system/bin.
+// It is required because the default path used by execve() is wrong on android.
+static void
----------------
(nit): Please move this comment into the ifdef __ANDROID__ block

================
Comment at: source/Host/linux/ProcessLauncherLinux.cpp:49
@@ +48,3 @@
+    write(error_fd, os.str().data(), os.str().size());
+    _exit(1);
+}
----------------
Should we close the file descriptor before exiting?


https://reviews.llvm.org/D22457