[Lldb-commits] [PATCH] D22457: Unify process launching code on linux

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 18 04:29:32 PDT 2016


labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.

We've had two copies of code for launching processes:
- one in NativeProcessLinux, used for launching debugged processes
- one in ProcessLauncherAndroid, used on android for launching all other kinds of processes

These have over time acquired support for various launch options, but neither supported all of
them. I now replace them with a single implementation ProcessLauncherLinux, which supports all
the options the individual versions supported and set it to be used to launch all processes on
linux.

This also works around the ETXTBSY issue on android when the process is started from the platform
instance, as that used to go through the version which did not contain the workaround.

https://reviews.llvm.org/D22457

Files:
  include/lldb/Host/android/ProcessLauncherAndroid.h
  include/lldb/Host/linux/ProcessLauncherLinux.h
  source/Host/CMakeLists.txt
  source/Host/android/ProcessLauncherAndroid.cpp
  source/Host/common/Host.cpp
  source/Host/linux/ProcessLauncherLinux.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22457.64296.patch
Type: text/x-patch
Size: 30483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160718/d995dab7/attachment-0001.bin>


More information about the lldb-commits mailing list