[Lldb-commits] [lldb] r272087 - Revive the error message from "process load" and SBProcess::LoadImage.

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 7 18:29:21 PDT 2016

Author: jingham
Date: Tue Jun  7 20:29:21 2016
New Revision: 272087

URL: http://llvm.org/viewvc/llvm-project?rev=272087&view=rev
Revive the error message from "process load" and SBProcess::LoadImage.

IsPointedCString has problems with ValueObjects of type eTypeHostAddress.  We should
figure out the right thing to do in that case, but the test is silly here because we're
reading a type we've defined, so we know it is a const char *, and if the memory is good, 
we won't be able to read any characters, when we do ReadPointedString.



Modified: lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp?rev=272087&r1=272086&r2=272087&view=diff
--- lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp Tue Jun  7 20:29:21 2016
@@ -943,7 +943,7 @@ PlatformPOSIX::DoLoadImage(lldb_private:
     if (image_ptr == 0)
         ValueObjectSP error_str_sp = result_valobj_sp->GetChildAtIndex(1, true);
-        if (error_str_sp && error_str_sp->IsCStringContainer(true))
+        if (error_str_sp)
             DataBufferSP buffer_sp(new DataBufferHeap(10240,0));
             size_t num_chars = error_str_sp->ReadPointedString (buffer_sp, error, 10240).first;

More information about the lldb-commits mailing list