[Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Fri May 27 10:05:05 PDT 2016

tfiala added inline comments.

Comment at: include/lldb/Interpreter/Args.h:120
@@ -100,3 +119,3 @@
-    Dump (Stream *s);
+    Dump (Stream *s, const char *label_name) const;
clayborg wrote:
> I would make just one Dump function and default the label_name to "argv". No need for two functions.
Okay - I wasn't sure if we preferred to avoid default args  - they used to sometimes cause problems with stale compilations in some build systems, but we're probably way past that point nowadays.

I'll fix that up.  Also, I'll run it through the clang formatter.  I kept the formatting of the (unimplemented) header in ProcessInfo, but that was using the non-official space-before-the-paren style.


More information about the lldb-commits mailing list