[Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Fri May 27 10:02:43 PDT 2016


clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

See inlined comments.


================
Comment at: include/lldb/Interpreter/Args.h:120
@@ -100,3 +119,3 @@
     void
-    Dump (Stream *s);
+    Dump (Stream *s, const char *label_name) const;
 
----------------
I would make just one Dump function and default the label_name to "argv". No need for two functions.


http://reviews.llvm.org/D20722





More information about the lldb-commits mailing list