[Lldb-commits] Patch: Add additional nullptr check to SBValue::CreateValueFromData

[Enrico Granata via lldb-commits]

> On May 20, 2016, at 2:35 AM, Sebastian Theophil via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> SBValue::CreateValueFromData didn’t check if the SBType argument was in fact a nullptr. This leads to a crash when dereferencing it of course. I followed the naming used in SBValue CreateValueFromAddress above.
> 
> Regards,
> Sebastian
> 
> --
> Dr. Sebastian Theophil | stheophil at think-cell.com
> Senior Software Engineer
> 
> We are looking for C++ Developers: http://www.think-cell.com/career
> 
> think-cell Software GmbH | Chausseestr. 8/E | 10115 Berlin | Germany
> http://www.think-cell.com | phone +49 30 666473-10 | US phone +1 800 891 8091
> 
> Amtsgericht Berlin-Charlottenburg, HRB 85229 | European Union VAT Id DE813474306
> Directors: Dr. Markus Hannebauer, Dr. Arno Schödl
> <SBValue.cpp.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Sebastian,
Your patch LGTM - thanks for submitting it for review.

If you have commit access, feel free to commit yourself - otherwise I will gladly do it for you.

With that said, in general, LLDB patches go through review on http://reviews.llvm.org <http://reviews.llvm.org/>

Thanks,
- Enrico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160520/7093e1c7/attachment.html>