<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 20, 2016, at 2:35 AM, Sebastian Theophil via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">SBValue::CreateValueFromData didn’t check if the SBType argument was in fact a nullptr. This leads to a crash when dereferencing it of course. I followed the naming used in SBValue CreateValueFromAddress above.<br class=""><br class="">Regards,<br class="">Sebastian<br class=""><br class="">--<br class="">Dr. Sebastian Theophil | <a href="mailto:stheophil@think-cell.com" class="">stheophil@think-cell.com</a><br class="">Senior Software Engineer<br class=""><br class="">We are looking for C++ Developers: <a href="http://www.think-cell.com/career" class="">http://www.think-cell.com/career</a><br class=""><br class="">think-cell Software GmbH | Chausseestr. 8/E | 10115 Berlin | Germany<br class=""><a href="http://www.think-cell.com" class="">http://www.think-cell.com</a> | phone +49 30 666473-10 | US phone +1 800 891 8091<br class=""><br class="">Amtsgericht Berlin-Charlottenburg, HRB 85229 | European Union VAT Id DE813474306<br class="">Directors: Dr. Markus Hannebauer, Dr. Arno Schödl<br class=""><span id="cid:BD04C896962CC94D9162151F77CF8AE6@think-cell.com"><SBValue.cpp.patch></span>_______________________________________________<br class="">lldb-commits mailing list<br class=""><a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits<br class=""></div></div></blockquote></div><div class=""><br class=""></div>Sebastian,<div class="">Your patch LGTM - thanks for submitting it for review.</div><div class=""><br class=""></div><div class="">If you have commit access, feel free to commit yourself - otherwise I will gladly do it for you.</div><div class=""><br class=""></div><div class="">With that said, in general, LLDB patches go through review on <a href="http://reviews.llvm.org" class="">http://reviews.llvm.org</a></div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><i class="">- Enrico</i></div></body></html>