[Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

[Zachary Turner via lldb-commits]

It's too bad llvm doesn't have an equivalent of boost::any, because that
would be perfect here :-/

On Tue, May 10, 2016 at 12:39 PM Greg Clayton <clayborg at gmail.com> wrote:

> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> Just get rid of the extra typedef as specified in inline comments and this
> is good to go.
>
>
> ================
> Comment at: include/lldb/Host/HostProcess.h:41
> @@ -41,1 +40,3 @@
> +public:
> +    typedef Host::MonitorChildProcessCallback MonitorCallback;
>
> ----------------
> We can probably get rid of this and just use
> Host::MonitorChildProcessCallback
>
> ================
> Comment at: include/lldb/Host/HostProcess.h:54
> @@ -53,1 +53,3 @@
> +    HostThread
> +    StartMonitoring(const MonitorCallback &callback, bool
> monitor_signals);
>
> ----------------
> Use Host::MonitorChildProcessCallback directly.
>
> ================
> Comment at: include/lldb/Host/posix/HostProcessPosix.h:43
> @@ -43,1 +42,3 @@
> +    HostThread
> +    StartMonitoring(const HostProcess::MonitorCallback &callback, bool
> monitor_signals) override;
>  };
> ----------------
> Use Host::MonitorChildProcessCallback directly
>
>
> http://reviews.llvm.org/D20106
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160510/af3ff785/attachment.html>