[Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Tue May 10 12:39:05 PDT 2016
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just get rid of the extra typedef as specified in inline comments and this is good to go.
================
Comment at: include/lldb/Host/HostProcess.h:41
@@ -41,1 +40,3 @@
+public:
+ typedef Host::MonitorChildProcessCallback MonitorCallback;
----------------
We can probably get rid of this and just use Host::MonitorChildProcessCallback
================
Comment at: include/lldb/Host/HostProcess.h:54
@@ -53,1 +53,3 @@
+ HostThread
+ StartMonitoring(const MonitorCallback &callback, bool monitor_signals);
----------------
Use Host::MonitorChildProcessCallback directly.
================
Comment at: include/lldb/Host/posix/HostProcessPosix.h:43
@@ -43,1 +42,3 @@
+ HostThread
+ StartMonitoring(const HostProcess::MonitorCallback &callback, bool monitor_signals) override;
};
----------------
Use Host::MonitorChildProcessCallback directly
http://reviews.llvm.org/D20106
More information about the lldb-commits
mailing list