[Lldb-commits] [PATCH] D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput

Enrico Granata via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 29 10:11:43 PDT 2016

granata.enrico accepted this revision.
This revision is now accepted and ready to land.

Comment at: packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py:29
@@ -30,1 +28,3 @@
+        """Test that LLDB correctly allows scripted commands to set immediate output to the console."""
+        self.launch(timeout=5)
fjricci wrote:
> granata.enrico wrote:
> > Can we raise this a little bit? I worry that going all the way from 60 down to 5 might cause this test to start failing more in load scenarios. Maybe 10 would be a better value?
> I chose 5 because your original console unit test used 5. I changed it to 60 when I added the file aspects. I don't have a problem changing it to 10 though
10 is probably fine - the file version also seems to use 10, so I'd just make them consistent. Other than that LGTM.


More information about the lldb-commits mailing list