[Lldb-commits] [PATCH] D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput

[Francis Ricci via lldb-commits]

fjricci added inline comments.

================
Comment at: packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py:29
@@ -30,1 +28,3 @@
+        """Test that LLDB correctly allows scripted commands to set immediate output to the console."""
+        self.launch(timeout=5)
 
----------------
granata.enrico wrote:
> Can we raise this a little bit? I worry that going all the way from 60 down to 5 might cause this test to start failing more in load scenarios. Maybe 10 would be a better value?
I chose 5 because your original console unit test used 5. I changed it to 60 when I added the file aspects. I don't have a problem changing it to 10 though

================
Comment at: packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py:43
@@ +42,3 @@
+    @expectedFailureAll(oslist=["freebsd","linux"], bugnumber="llvm.org/pr26139")
+    def test_command_script_immediate_output_file (self):
+        """Test that LLDB correctly allows scripted commands to set immediate output to a file."""
----------------
granata.enrico wrote:
> Feel free to make the file version non pexpect-based if you want
I ended up finding clayborg's sendline bug-fix, so pexpect should be fine (actually probably preferred)


http://reviews.llvm.org/D19690