[Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 13 09:56:40 PDT 2016

labath added a comment.

In http://reviews.llvm.org/D19060#399915, @zturner wrote:

> Ahh that's unfortunate. I guess the thing to do is make SetFile and
>  SetDirectory. At least by changing the return type we can get the compiler
>  to tell us everywhere this is happening. Did you run the test suite on
>  Windows to make sure this doesnt break anything?

Yeah, I had something like that in mind.

I didn't run the windows test suite, but I'd be very surprised if it broke anything, since I'm basically just restoring the previous behavior (before I started messing with this function, we were always running the normalization).


More information about the lldb-commits mailing list