[Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

[Sean Callanan via lldb-commits]

spyffe accepted this revision.
spyffe added a comment.

Looks good to me.  Thanks for the fix!


================
Comment at: source/Expression/IRExecutionUnit.cpp:802
@@ -801,3 +801,3 @@
 
-                load_address = candidate_sc.symbol->ResolveCallableAddress(*target);
+                    load_address = candidate_sc.symbol->ResolveCallableAddress(*target);
 
----------------
Ah yes, I see what's being fixed here.  This looks fine.  I like Adrian's recommended early-out policy but this isn't a hard-and-fast rule.  It seems like doing the logic the way you're doing it is less invasive, so I'm fine with doing it this way for now.


http://reviews.llvm.org/D17860