[Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 8 10:26:14 PST 2016

amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

Thanks for the fix.

Right now I'm trying to figure out why the test framework didn't detect the crash and reported that all the tests passed.

Comment at: source/Expression/IRExecutionUnit.cpp:800
@@ -801,1 +799,3 @@
+                if (candidate_sc.symbol)
+                {
I'm OK with this, but I believe the LLDB style is to reverse the logic and use an early-out (a `continue` in this case) rather than increasing the depth of the rest of the code.


More information about the lldb-commits mailing list