[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

[Cameron via lldb-commits]

cameron314 added a comment.

Absolutely, I'm rebasing now. This is unfortunately the type of patch that rots really quickly ;-)

I did run `check-lldb` locally at one point, with no major differences before and after the patch. But I recently discovered the version of Python I'd compiled had accidentally been compiled with VS2008, and since the tip's changed anyway, it's absolutely worth running them again. This was the day before the instructions to use VS21015 with Python 3 were posted, haha.


================
Comment at: lldb/trunk/source/Host/common/File.cpp:330
@@ +329,3 @@
+        }
+        ::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYWR, mode);
+#else
----------------
zturner wrote:
> Any particular reason you're using `_SH_DENYWR` instead of `_SH_DENYNO`?  No matter what we do we will always have subtle differences in semantics, but `_SH_DENYNO` is closer to posix semantics.
No particular reason other than I find `_SH_DENYWR` a reasonable default. It generally doesn't hurt to let others read the file while it's being written, and that's sometimes crucial (e.g. for log files which are written to incrementally and only closed at the very end). I can change it if you prefer.


http://reviews.llvm.org/D17107