[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 7 11:07:40 PST 2016

zturner added a comment.

Can you rebase against tip of trunk?  I want to apply and run the test suite with the patch applied, but I'm getting a lot of errors.  After uploading a new rebased patch, can you also respond with the revision you rebased against so I can make sure I'm at the same place.

Comment at: lldb/trunk/source/Host/common/File.cpp:330
@@ +329,3 @@
+        }
+        ::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYWR, mode);
Any particular reason you're using `_SH_DENYWR` instead of `_SH_DENYNO`?  No matter what we do we will always have subtle differences in semantics, but `_SH_DENYNO` is closer to posix semantics.


More information about the lldb-commits mailing list