[Lldb-commits] [lldb] r261593 - Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectCommands.cpp; other minor fixes.

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 23 03:27:24 PST 2016

I agree with Adrian. I don't think the section comments are supposed
to apply to the "main header file", which should always come first.

On 23 February 2016 at 00:17, Eugene Zelenko via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
> On Mon, Feb 22, 2016 at 4:14 PM, Adrian McCarthy <amccarth at google.com> wrote:
>> It looks like this patch reorders the #includes in a way that seems contrary
>> to general practice.  In particular, if foo.cpp has a header foo.h, then it
>> should include foo.h before any other files.  This helps ensure that foo.h
>> can stand alone and won't require clients to have to figure out what else
>> must be included.
>> http://llvm.org/docs/CodingStandards.html#include-style
>> I know LLDB doesn't always follow LLVM guidelines, but this seems pretty
>> common and intentional.
> I try to follow headers section comments.
> Eugene.
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

More information about the lldb-commits mailing list